fix: more test and pylint quality

openedx · Sep 26, 2024 · d7088c5 · d7088c5
1 parent ee346d4
commit d7088c5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/course_discovery/apps/course_metadata/management/commands/populate_product_catalog.py b/course_discovery/apps/course_metadata/management/commands/populate_product_catalog.py
@@ -86,7 +86,7 @@ def get_products(self, product_type, product_source):
                 queryset = queryset.filter(type__slug=CourseType.BOOTCAMP_2U)
 
             if product_source:
-                queryset.filter(product_source__slug__in=product_source.split(','))
+                queryset = queryset.filter(product_source__slug__in=product_source.split(','))
 
             queryset = queryset.annotate(
                 num_orgs=Count('authoring_organizations')
@@ -109,7 +109,7 @@ def get_products(self, product_type, product_source):
                 .select_related('partner', 'type', 'primary_subject_override', 'language_override')
 
             if product_source:
-                queryset.filter(product_source__slug__in=product_source.split(','))
+                queryset = queryset.filter(product_source__slug__in=product_source.split(','))
 
             queryset = queryset.annotate(
                 num_orgs=Count('authoring_organizations')

diff --git a/...discovery/apps/course_metadata/management/commands/tests/test_populate_product_catalog.py b/...discovery/apps/course_metadata/management/commands/tests/test_populate_product_catalog.py
@@ -346,7 +346,7 @@ def test_populate_product_catalog_with_degrees_having_overrides(self):
                 self.assertEqual(row["Title"], degree.title)
                 self.assertIn(degree.primary_subject_override.name, row["Subjects"])
                 self.assertEqual(row["Languages"], degree.language_override.code)
-    
+
     def test_populate_product_catalog_supports_multiple_product_sources(self):
         """
         Test that the populate_product_catalog command supports multiple product sources.