-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add squad field to onboarding form #963
Conversation
Adds an optional `squad` field to the onboarding ticket template. Also rename the `push-pull-all` team to `2u-edx-legacy`.
id: squad | ||
attributes: | ||
label: User Squad | ||
description: If the users specified above are members of a named squad or team at your firm, optionally specify it here. This will help simplify access management in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make the distinction between squad and Github team? Does it matter if folks put in a Github team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know - probably a question for Ned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, i don't know what information the 2U help desk will have when they fill this out. This seems like a fine description to start with.
@@ -49,7 +54,7 @@ body: | |||
id: requests | |||
attributes: | |||
label: Special Requests | |||
description: For now, all new 2U/edX employees will be granted access to `push-pull-all`. If these users need to be added to any specific teams or given any elevated privileges, note them here. | |||
description: For now, all new 2U/edX employees will be granted access to `2u-edx-legacy`. If these users need to be added to any specific Github teams or given any elevated privileges, note them here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we weren't adding new people to 2u-edx-legacy? I know there are newer engineers who are not in the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe that was just a hiccup? It looks like even newer people are in the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, we're still supposed to add people to it if requested. What's fuzzy to me is if it's not requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing we can deal with the wording here separately, so going ahead and merging the PR.
Adds an optional
squad
field to the onboarding ticket template.Also rename the
push-pull-all
team to2u-edx-legacy
.