fix: Pass the github token to all jobs in the workflows. #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't passing the GITHUB_TOKEN to both steps of the quarterly task which was causing it to fail on the first step which didn't pass the GITHUB_TOKEN. Rather than just fixing the one step, I updated both the quarterly and weekly file to pass the GITHUB_TOKEN env to all jobs/steps in their respective workflow files. Since these files should be only github issue creation commands I think this is fine to do and simplifes things and makes the workflows less error prone.
sarina
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't passing the GITHUB_TOKEN to both steps of the quarterly task
which was causing it to fail on the first step which didn't pass the
GITHUB_TOKEN.
Rather than just fixing the one step, I updated both the quarterly and
weekly file to pass the GITHUB_TOKEN env to all jobs/steps in their
respective workflow files. Since these files should be only github
issue creation commands I think this is fine to do and simplifes things
and makes the workflows less error prone.