fix: fallback check for identifying github requests #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes requesters will remove `[GH Request]` from their issue title without realizing the implications, so we have a fall back check for `Firm Name` as the beginning of the request body. This fallback check is a great idea but it was broken because the request template actually generates issues beginning with `## Firm Name`, not `Firm Name`. This commit should fix that, making it less likely that we miss oncall requests in the future.
brian-smith-tcril
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes requesters will remove
[GH Request]from their issue title withoutrealizing the implications, so we have a fall back check for
Firm Nameas thebeginning of the request body.
This fallback check is a great idea but it was broken because the request
template actually generates issues beginning with
## Firm Name, notFirm Name. This commit should fix that, making it less likely that we miss oncallrequests in the future.