Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tox<4.0.0 to constraints.txt #232

Closed
wants to merge 1 commit into from
Closed

chore: Add tox<4.0.0 to constraints.txt #232

wants to merge 1 commit into from

Conversation

ZiqiXiao
Copy link
Contributor

@ZiqiXiao ZiqiXiao commented Oct 19, 2023

Description: Add tox<4.0.0 to constraints.txt

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 19, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ZiqiXiao! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@ZiqiXiao ZiqiXiao changed the title Add tox<4.0.0 to constraints.txt(public-engineering#217) chore: Add tox<4.0.0 to constraints.txt Oct 19, 2023
Copy link
Contributor Author

@ZiqiXiao ZiqiXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tox<4.0.0 to constraints.txt (public-engineering#217)

@ZiqiXiao ZiqiXiao closed this Oct 19, 2023
@openedx-webhooks
Copy link

@ZiqiXiao Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@ZiqiXiao ZiqiXiao deleted the ZiqiXiao-patch-1 branch October 19, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants