-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecommenderXBlock: Drop py3.8 support | Replace pkg_resources lib with importlib.resources #98
Conversation
Thanks for the pull request, @beingfaisal! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @beingfaisal! Thanks for this contribution! If you are contributing on behalf of edly, please have your manager reach out to [email protected] to add you to our existing agreement. Thanks! |
@beingfaisal All seems ok to me, but will be great to cover following issue within this PR and add support of Python 3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requrest an addition
@beingfaisal are you on the Arbisoft team? |
@beingfaisal looks like your branch needs some conflicts resolved, can you have a look? Otherwise the checks are all passing. |
159ea8c
to
98b9851
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 change
.github/workflows/ci.yml
Outdated
@@ -16,7 +16,7 @@ jobs: | |||
matrix: | |||
os: | |||
- ubuntu-latest | |||
python-version: ['3.8', '3.11'] | |||
python-version: ['3.11'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beingfaisal Please add support of 3.12 as well, change to
python-version: ['3.11', '3.12']
Issue - Move on from deprecated pkg_resources api
Issue - Drop Python 3.8 & Add Support for Python 3.12
Screenshots