-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConceptXBlock | Drop py3.8 support | replace pkg_resource with importlib.resources #161
Conversation
…rces * chore: transitioned from pkg_resources api to importlib-resources api * feat!: drop support for python 3.8
Thanks for the pull request, @OmerBhatti! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @OmerBhatti! As mentioned in other pull requests - please have your manager reach out to [email protected] to have you added to edly's existing contributor agreement. Thanks! |
@feanil @kdmccormick |
@OmerBhatti Screen shot seems not rendered properly or is it the right behaviour, can you please check them before this PR |
af0237b
to
dd49d38
Compare
dd49d38
to
a454513
Compare
ConceptXblock requires a server url from where it fetches data.
i don't know what kind of data it expects that why it is rendering empty without the server url. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the version so we could push the release
66c3711
to
b90be90
Compare
b90be90
to
a576ffb
Compare
Ticket: Move on from deprecated pkg_resources api #159
PR is expected to merge after merging this PR : chore: Upgrade Python requirements
Followed migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html
Testing:
I have tested the changes with following steps:
Screenshots