Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix pypi publish workflow build #126

Merged
merged 5 commits into from
Jan 25, 2024
Merged

fix: fix pypi publish workflow build #126

merged 5 commits into from
Jan 25, 2024

Conversation

UsamaSadiq
Copy link
Member

Description

  • Fixed the failing pypi upgrade action build.
  • Tested by triggering the custom check on the pull_request.

iamsobanjaved
iamsobanjaved reviewed Jan 25, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
iamsobanjaved
iamsobanjaved approved these changes Jan 25, 2024
View reviewed changes
Copy link

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change needed

setup.py Outdated Show resolved Hide resolved
@UsamaSadiq @iamsobanjaved
docs: update setup.py
ca8a3b5 
Co-authored-by: Muhammad Soban Javed <[email protected]>
@UsamaSadiq UsamaSadiq merged commit af3f6bd into master Jan 25, 2024
2 checks passed
@UsamaSadiq UsamaSadiq deleted the fix-failing-pypi-job branch January 25, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UsamaSadiq @iamsobanjaved