Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add sqlite artifact in repo health job #104

Merged
merged 1 commit into from
Dec 14, 2023
Merged

build: add sqlite artifact in repo health job #104

merged 1 commit into from
Dec 14, 2023

Conversation

UsamaSadiq
Copy link
Member

Description

@UsamaSadiq UsamaSadiq requested review from feanil and jmbowman December 8, 2023 10:43
jmbowman
jmbowman approved these changes Dec 11, 2023
View reviewed changes
Copy link

@jmbowman jmbowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, should be ready for Axim review once openedx/edx-repo-health#430 is merged.

@feanil
Copy link
Contributor

feanil commented Dec 12, 2023

Let me know when y'all think this is ready for review and merging.

@UsamaSadiq
Copy link
Member Author

@feanil I'm currently testing some final changes. Will ping you again once the PR is ready for review now.

@UsamaSadiq
Copy link
Member Author

Moved the artifact generation step in the reusable workflow as well so it will be available for the community. Tested the change through the fork in custom build which passed successfully and artifacts were created as expected.

@UsamaSadiq
Copy link
Member Author

@feanil this PR has been tested thoroughly and is now ready to be merged after your review. Please review and merge this. Thanks.

feanil
feanil approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, makes sense and I see that the corresponding edx-repo-health PR has merged to add this script to that repo.

@feanil feanil merged commit 91e4912 into openedx:master Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbowman jmbowman jmbowman approved these changes

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UsamaSadiq @feanil @jmbowman