Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Deprecate User Retirement Scripts #736

Merged

Conversation

farhan
Copy link
Contributor

@farhan farhan commented Feb 17, 2024

ticket: openedx/axim-engineering#881

Deprecate the user-retirement scripts that are migrated within edx-platform repo

Relevant PR: openedx/edx-platform#34063
Follow up removal PR: #734

Pending:

  • Update the deprecation comment once relevant PR merged in edx-plarform

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (82f39d6) to head (5bed44c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   74.65%   74.69%   +0.03%     
==========================================
  Files         105      106       +1     
  Lines        8595     8616      +21     
==========================================
+ Hits         6417     6436      +19     
- Misses       2178     2180       +2     
Flag Coverage Δ
unittests 74.69% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@farhan farhan marked this pull request as ready for review February 19, 2024 08:51
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, as a part of this, please also update the README for this repo to indicate which scripts have been moved and link to the new location.

@farhan farhan force-pushed the farhan/deprecate-user-retirement-code branch from baacaed to e4f1ab9 Compare February 23, 2024 11:12
@farhan farhan force-pushed the farhan/deprecate-user-retirement-code branch from e4f1ab9 to 5bed44c Compare February 23, 2024 11:14
@farhan
Copy link
Contributor Author

farhan commented Feb 23, 2024

@feanil Added details in readme, please have a look

If approved, please merge and notify this change to 2U SRE team, give them 2-4 weeks to schedule updating their internal tooling before we merge this Tubular PR
Ask 2U SRE team to make sure all the required resides in edx-platform repo. now

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I'll coordinate and merge!

@feanil feanil merged commit 1b8a6cb into openedx-unsupported:master Feb 26, 2024
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants