-
Notifications
You must be signed in to change notification settings - Fork 33
feat: allowing studio asides for course-authoring MFE #452
Conversation
Thanks for the pull request, @Anas12091101! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @Anas12091101! Thanks so much for this contribution! Please let me know if you have any questions on submitting a CLA form. Thanks! |
@mphilbrick211 Anas should be covered by the MIT Entity agreement. I don't know if you have access, but I've added him to the list at https://docs.google.com/spreadsheets/d/1HEaYDtoBtN-vvloA5UC-4oAHTVGzWbJWYVzYrEwFT4Y/edit#gid=755274227&range=28:28 |
I've added him. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
==========================================
+ Coverage 90.51% 90.60% +0.09%
==========================================
Files 227 228 +1
Lines 4110 4160 +50
Branches 825 842 +17
==========================================
+ Hits 3720 3769 +49
- Misses 369 371 +2
+ Partials 21 20 -1 ☔ View full report in Codecov by Sentry. |
@Anas12091101 please add a section to the PR description with instructions on how to test this. It requires installing an xBlock that uses the asides functionality, right? |
@pdpinch I was testing the functionality to create a screen cast and found some bugs in the functionality due to which the asides are not loading and throwing an error. I will write the testing instructions once I find the solution for this |
Ok. I'm going to change this to "waiting on author" then. |
I've fixed the problem in the edx-platform PR and have added the test steps in this PR's description |
@Anas12091101 @pdpinch is this PR still ready to go? We've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against https://github.com/openedx/frontend-app-course-authoring/ if you'd like to continue it. Feel free to reach out to me if you aren't sure how to do that using git and I can help (basically: add your local |
@Anas12091101 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Supporting Information
Issue: Frontend App Course Authoring - Issue #545
EdX Platform PR: EdX Platform - Pull Request #34026
Note: This pull request should be reviewed concurrently with the EdX Platform PR.
Description
The current problem editor page lacks options for configuring aside values of the problem xblock. This pull request addresses this by enabling the asides' studio views in the problem editor.
More information in the EdX Platform PR
Note: Styles are not finalized, and suggestions for improvement are welcome.
Screenshot
How to test locally
(Note: The styling of the iframe has not been completed yet. The PR only offers a basic approach to resolve openedx/frontend-app-authoring#545. It should be merged after the edx-platform PR is merged.)