-
Notifications
You must be signed in to change notification settings - Fork 20
build: use shared browserslist configuration #63
Conversation
Thanks for the pull request, @Mashal-m! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Pull Request Test Coverage Report for Build 3489579138
💛 - Coveralls |
Codecov ReportBase: 57.28% // Head: 57.28% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 57.28% 57.28%
=======================================
Files 26 26
Lines 398 398
Branches 66 66
=======================================
Hits 228 228
Misses 154 154
Partials 16 16 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@schenedx Ready for your team whenever. |
@Mashal-m Why is this PR created? Why do we want to adopt using browser-list-config instead of what's already there? The description is empty and that would make it difficult for reviewer to understand the intent. |
@schenedx This change reduces the resultant asset bundle size. |
3b166c9
to
55d997f
Compare
@Mashal-m I had to make some updates to packages.json to get this deployable again and I have rebased your package.json changes on top of those, merging them in was very easy, and then rebuilt package locks |
failing test is just a failure to upload to codecov which has been intermittently annoying me over the past couple of days, I'm going to merge and recheck on stage |
deployed, looks OK |
Ticket:
Use shared @edx/browserslist-config
Removes custom
browserslist
configuration in favor of using a Shared ConfigurationThis change reduces the resultant asset bundle size.