fix: improve showing of IAP unlock controller (#1828)

Source/CourseUpgradeHelper.swift

@@ -238,6 +238,12 @@ class CourseUpgradeHelper: NSObject {
         }
     }
 
+    // presented view appears on the unlock controller
+    // need to bring it to front for better user experience
+    func bringLoaderToFront() {
+        unlockController.bringToFront()
+    }
+
     func removeLoader(success: Bool? = false, removeView: Bool? = false, completion: (()-> ())? = nil) {
         self.completion = completion
         if success == true {

Source/NewCourseDashboardViewController.swift

@@ -118,6 +118,10 @@ class NewCourseDashboardViewController: UIViewController, InterfaceOrientationOv
         navigationItem.setHidesBackButton(true, animated: true)
         navigationController?.setNavigationBarHidden(true, animated: true)
         environment.analytics.trackScreen(withName: OEXAnalyticsScreenCourseDashboard, courseID: courseID, value: nil)
+
+        if let _ = courseUpgradeHelper.courseUpgradeModel {
+            courseUpgradeHelper.bringLoaderToFront()
+        }
     }
 
     override func viewWillDisappear(_ animated: Bool) {

Source/ValuePropUnlockViewContainer.swift

@@ -48,6 +48,14 @@ class ValuePropUnlockViewContainer: NSObject {
         }
     }
 
+    // the bring subview to front isn't work here because of hierarchy
+    // removing and readding the view
+    func bringToFront() {
+        removeView() { [weak self] in
+            self?.showView()
+        }
+    }
+
     @objc private func finishTimer() {
         shouldDismiss.value = true
     }