-
Notifications
You must be signed in to change notification settings - Fork 253
feat: add variant_id to seat info for ExecEd courses #4084
feat: add variant_id to seat info for ExecEd courses #4084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise, it looks alright. I am going to rely on owner and/or Enterprise for better context here.
Have you verified that this works as intended? I believe you need to define the new attribute |
If I am correct here^, I expect we'll need something like 3782 |
Not this time, but during my work on this pull request, I had tested these changes with the value of [thinking] It seems like it is currently adding Nice catch 💯 |
6433ec4
to
215511e
Compare
215511e
to
015f90a
Compare
015f90a
to
49f6fc3
Compare
Description
In continue to the PR: #3794
This PR adds the functionality to add
variant_id
toseat_info
for execEd courses via publication endpoint⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.
Useful information to include:
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?
Other information
Include anything else that will help reviewers and consumers understand the change.