This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feat: Initial 3DS implementation and handle requires_action status #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/REV-3240/three-d-secure
branch
8 times, most recently
from
9fe9d46
to
f085a96
Compare
| self.record_payment(basket, handled_processor_response) | ||
| properties.update({'total': handled_processor_response.total, 'success': True, }) | ||
| # For payments that require 3DS auth, tell MFE to handle | ||
| if 'requires_action' in handled_processor_response._fields: |
There was a problem hiding this comment.
does the requires_action key only show up in the handled_processor_response if it's a 3DS event?
There was a problem hiding this comment.
That's correct, comes from the named tuple I created RequiresActionProcessorResponse vs. the existing HandledProcessorResponse. At this point in the code I don't distinguish btw them (variable name is handled_processor_response) because they both could come from the same handle function.
From my testing if it's not present, it does not error out but happy to modify the code if you find a better way!
julianajlk
commented
Feb 3, 2023
| @@ -153,6 +153,159 @@ | |||
| "transfer_data": null, | |||
| "transfer_group": null | |||
| }, | |||
| "confirm_resp_three_d_secure": { | |||
There was a problem hiding this comment.
I'm not sure I need all of this here, the only difference between the confirm_resp is the status.
pshiu
reviewed
Feb 6, 2023
julianajlk
force-pushed
the
julianajlk/REV-3240/three-d-secure
branch
from
f085a96
to
d24cb96
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-3240.
In order for 3DS to happen for the credit cards that require 3DS authentication, on Payment Intent confirmation with Stripe, we can now remove
error_on_requires_action=Truesince MFE will be able to handle 3DS and does not need to error out. Areturn_urlis also provided so the learner can be redirected after 3DS authentication is done on their bank's website.Note: