Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Update LMSPublisher to not convert price to integer #3316

Closed

Conversation

julianajlk
Copy link
Contributor

@julianajlk julianajlk commented Feb 5, 2021

REV-1632.

Background:
The min_price column in LMS CourseMode table takes integers, and should be updated to take decimals to match the price in ecommerce database, making the price across the learner pathway to purchase the same (49.99 vs. 49).

This ticket covers:
Currently, ecommerce serializes the price as an int before sending a request to LMS - this ticket removes this conversion so that it's converted to a float instead, keeping the digits, then LMS will handle the conversion to the appropriate type it needs in the CourseMode table.

In order to decrease the risk of breaking anything with migrations, this change will be divided into 5 steps across edx-platform and ecommerce:

  1. Deploy LMS no.1 (PR here): make sure min_price can receive non-int.
  2. Deploy ecommerce no.1 (this PR): change LMSPublisher to stop converting min_price to int.
  3. Deploy LMS no.2 (WIP PR here): add new column for price and make sure it's populated with the same min_price, and that min_price can receive a Decimal.
  4. Deploy LMS no.3 : use new price column in Track Selection and Course Home pages.
  5. Deploy LMS no. 4 : remove original min_price column.

@julianajlk julianajlk force-pushed the julianajlk/REV-1632/price-discrepancy-coursemode branch 2 times, most recently from 77c892a to 57ed0f1 Compare February 9, 2021 18:39
@julianajlk julianajlk force-pushed the julianajlk/REV-1632/price-discrepancy-coursemode branch from 57ed0f1 to d874fc3 Compare February 12, 2021 17:55
@julianajlk julianajlk force-pushed the julianajlk/REV-1632/price-discrepancy-coursemode branch from d874fc3 to 1f29582 Compare February 12, 2021 18:45
@julianajlk
Copy link
Contributor Author

Closing as this work was reprioritized.

@julianajlk julianajlk closed this Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant