This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Update LMSPublisher to not convert price to integer #3316
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-1632.
Background:
The
min_price
column in LMSCourseMode
table takes integers, and should be updated to take decimals to match the price in ecommerce database, making the price across the learner pathway to purchase the same (49.99 vs. 49).This ticket covers:
Currently, ecommerce serializes the price as an
int
before sending a request to LMS - this ticket removes this conversion so that it's converted to a float instead, keeping the digits, then LMS will handle the conversion to the appropriate type it needs in theCourseMode
table.In order to decrease the risk of breaking anything with migrations, this change will be divided into 5 steps across edx-platform and ecommerce:
min_price
can receive non-int.LMSPublisher
to stop convertingmin_price
to int.min_price
, and thatmin_price
can receive a Decimal.min_price
column.