Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: install atlas in edx_django_service #6967

Closed
wants to merge 1 commit into from
Closed

feat: install atlas in edx_django_service #6967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions playbooks/roles/edx_django_service/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,19 @@
- install:system-requirements
when: edx_django_service_npm_version is defined and not edx_django_service_enable_experimental_docker_shim


- name: install Open edX Atlas translation tool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to do this as a part of "install production requirements" or "install extra requirements" instead? It seems that's likely the more common pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-smith-tcril So we have two options:

  • Go to each service like credentials, ecommerce and others and add openedx-atlas to its base.in requirements file, or
  • Add the requirement in configuration (this PR)

I realize now that this is a questionable approach to add it here, but I'm open to hear from you and other reviewers.

I'm realizing we should close this pull request and install atlas in individual repos instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to each service like credentials, ecommerce and others and add openedx-atlas to its base.in requirements file

I think I like this idea best, but I'm very open to any other thoughts/opinions on the matter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've became hesitant after completing this PR, so I close it and move on adding atlas to each repo individually.

It'll take more time to add to each individual service, but honestly it's the least surprising place to specify a requirement.

I'll close this PR and start working on the individual repos.

pip:
name: "openedx-atlas"
version: "0.4.4"
extra_args: "--exists-action w"
virtualenv: "{{ edx_django_service_venv_dir }}"
state: present
become_user: "{{ edx_django_service_user }}"
tags:
- install
- install:app-requirements

- name: install production requirements
command: make production-requirements
args:
Expand Down
Loading