Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge recent changes into master (Planet-N / headless browser update / Poetry v2) #126

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

Criamos
Copy link
Contributor

@Criamos Criamos commented Jan 7, 2025

This PR merges the recent changes from #125 into master.

Please upgrade your poetry installation to >= v2.0.0
and make sure that your local venv is using a Python 3.13 interpreter!

- feat: hide cookiebanner in thumbnails (by forging the cookiebanner response)
  - Planet-N uses the "Simple Cookie Control" WordPress Plugin (see: https://wordpress.com/plugins/simple-cookie-control), which sets a cookie after accepting/declining the dialog (for 6 months)
- see: https://github.com/browserless/browserless/pkgs/container/chrome/327417313?tag=v2.24.1
  - changelog: https://github.com/browserless/browserless/blob/main/CHANGELOG.md#v2241
- change: to keep the docker-compose.yml in sync with the Kubernetes Helm Chart for Staging and Prod, switching back to "headless/chrome" (instead of the recently used "headless/chromium" image)
- this fixes the playwright wheel warning that first occurred with v1.49.0 (see: https://github.com/microsoft/playwright-python/releases/tag/v1.49.1)
- the recent browserless update apparently changed the API endpoint from "ws://localhost:3000" to "ws://localhost:3000/chrome/playwright", which can be accessed via playwright's "Browsertype.connect()"-method
  - the "connect_over_cdp()"-method seems no longer necessary

for future reference:
- the docs at https://docs.browserless.io/#connect-using-puppeteer-or-playwright appear to be outdated and don't reflect these recent changes
  - use "http://localhost:3000/docs" to look up the most-current documentation for the browserless playwright integration instead
planet_n_spider v0.0.4 / dependency updates and CI/CD migration to Poetry v2.0
@Criamos Criamos self-assigned this Jan 7, 2025
@Criamos Criamos marked this pull request as ready for review January 7, 2025 16:56
@Criamos Criamos merged commit 62370f0 into master Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant