chore(api/io-engine,csi): migrate from api repo #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
dsavitskiy,
hrudaya21,
Abhinandan-Purkait,
datacore-vvarakantham and
dsharma-dc
hrudaya21
approved these changes
Oct 26, 2023
Abhinandan-Purkait
approved these changes
Oct 27, 2023
abhilashshetty04
approved these changes
Oct 27, 2023
|
typo in the commit title |
datacore-vvarakantham
approved these changes
Oct 27, 2023
tiagolobocastro
force-pushed
the
migrate-api
branch
from
109a28d to
e762199
Compare
tiagolobocastro
changed the title
Signed-off-by: Tiago Castro <[email protected]>
Type on the wire used a different sign so just use the wire type directly. Add impls from prost-wkt crate, and reflect this in the description. Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
migrate-api
branch
from
e762199 to
823e6ca
Compare
good catch, fixed on both PR and commit |
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
migrate-api
branch
from
823e6ca to
310120b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.