feat: add features to control git-version #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added git dependencies: fusion-engineering/rust-git-version#19 This allows us to avoid rebuilds when staging changes. Also added another feature to avoid rebuilds altogether. Eg: if git versions are specified via env variable then we don't need to use git from within the rust-build at all. This is fine for most dev setups if we don't care about versions locally testing. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
git-deps
branch
from
ef52b3f to
46a057c
Compare
Abhinandan-Purkait
approved these changes
Feb 10, 2023
tiagolobocastro
added a commit
that referenced
this pull request
Feb 10, 2023
Added git dependencies: fusion-engineering/rust-git-version#19 This allows us to avoid rebuilds when staging changes. Also added another feature to avoid rebuilds altogether. Eg: if git versions are specified via env variable then we don't need to use git from within the rust-build at all. This is fine for most dev setups if we don't care about versions locally testing. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
added a commit
that referenced
this pull request
Feb 10, 2023
Added git dependencies: fusion-engineering/rust-git-version#19 This allows us to avoid rebuilds when staging changes. Also added another feature to avoid rebuilds altogether. Eg: if git versions are specified via env variable then we don't need to use git from within the rust-build at all. This is fine for most dev setups if we don't care about versions locally testing. Signed-off-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added git dependencies:
fusion-engineering/rust-git-version#19
This allows us to avoid rebuilds when staging changes.
Also added another feature to avoid rebuilds altogether. Eg: if git versions are specified via env variable then we don't need to use git from within the rust-build at all. This is fine for most dev setups if we don't care about versions locally testing.
Signed-off-by: Tiago Castro [email protected]