Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wp4 cfhp update #44

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Wp4 cfhp update #44

merged 5 commits into from
Oct 3, 2024

Conversation

mathvansoest
Copy link
Collaborator

No description provided.

@mathvansoest mathvansoest requested a review from EtienneKras July 17, 2024 12:39
EtienneKras
EtienneKras reviewed Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@EtienneKras EtienneKras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you merged WP3 in this branch, difficult to review and many files have the same changes. Could we first merge either this one or WP3 when done and then check if we get any conflicts while merging this one?

@EtienneKras EtienneKras merged commit bdb245b into main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneKras EtienneKras EtienneKras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathvansoest @EtienneKras