Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix failing election term tests and CI #305

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Apr 15, 2021

Issue #, if available:

Description of changes:
Fix the failing election term test. Enable the collector (by mocking)

Reduce the test coverage limit to 0.7 to avoid build failure.
Tracking the task to increase coverage in this issue (#306)

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link
Contributor

@yu-sun-77 yu-sun-77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please check why coverage report is not shown up even all checks are successful?

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ea643fe). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 50418e1 differs from pull request most recent head 7727425. Consider uploading reports for the commit 7727425 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage        ?   72.34%           
  Complexity      ?      338           
=======================================
  Files           ?       43           
  Lines           ?     2068           
  Branches        ?      146           
=======================================
  Hits            ?     1496           
  Misses          ?      468           
  Partials        ?      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea643fe...7727425. Read the comment docs.

@sruti1312 sruti1312 merged commit 7e0d2f8 into main Apr 15, 2021
@sruti1312 sruti1312 deleted the partsrut-test-failure branch April 15, 2021 18:30
khushbr pushed a commit that referenced this pull request Jun 10, 2021
cr https://code.amazon.com/reviews/CR-50314382

commit 2eb3872b0d3bfde09719497440019eeb7061dd7b
Merge: fa1ac709 a3877ba
Author: Khushboo Rajput <[email protected]>
Date:   Tue May 4 21:08:59 2021 -0700

    Merge branch 'main' into aes_7.10_nightly

commit fa1ac70933ae5c1939c4a0fa30f50f81925a07ab
Merge: fac4f8b8 c70b19d
Author: Khushboo Rajput <[email protected]>
Date:   Tue May 4 21:04:35 2021 -0700

    Merge branch 'aes_7.10_gh' into aes_7.10_nightly

commit a3877ba
Author: Sruti Parthiban <[email protected]>
Date:   Thu Apr 15 12:21:34 2021 -0700

    Fix format error (#309)

commit 7e0d2f8
Author: Sruti Parthiban <[email protected]>
Date:   Thu Apr 15 11:30:34 2021 -0700

    Fix failing election term tests (#305)

commit ea643fe
Author: meetshah777 <[email protected]>
Date:   Thu Apr 1 02:29:45 2021 +0530

    Changed master total PendingQueueSize to PendingQueueSize per task type (#296)

    * Changed master total PendingQueueSize to PendingQueueSize per task type

    * Addressed comments

    Co-authored-by: Meet Shah <[email protected]>

commit bf6a4cc
Author: meetshah777 <[email protected]>
Date:   Thu Apr 1 02:27:24 2021 +0530

    Added Election Term Metric (#297)

    * Changed master total PendingQueueSize to PendingQueueSize per task type

    * Added Election Term Metric

    * Formmated files

    * Merge conflict resolved

    * Addressed comments

    Co-authored-by: Meet Shah <[email protected]>

commit 130a494
Author: Mital Awachat <[email protected]>
Date:   Thu Mar 25 23:35:49 2021 +0530

    AdmissionControl: Clear metricQueue before running test (#300)

    Co-authored-by: Mital Awachat <[email protected]>

commit 3e6b8ec
Author: Joshua Tokle <[email protected]>
Date:   Wed Mar 24 19:07:06 2021 -0700

    Configure spotless plugin and enable code formatting (#276)

    * Configure spotless plugin and enable code formatting

    * Remove checkstyle and @ignore flaky tests

commit fac4f8b835e793e3db5240f1e4d1448fd9d16baa
Merge: 253229a2 f7b430b
Author: Khushboo Rajput <[email protected]>
Date:   Tue Mar 23 17:14:37 2021 -0700

    Merge branch 'main' into aes_7.10_nightly

commit f7b430b
Author: Dharmesh <[email protected]>
Date:   Wed Mar 24 05:25:20 2021 +0530

    [Build Fix]Removing the typecasting to IndexingPressure class to fix build failure while backporting (#293)

commit d49a701
Author: amathur1893 <[email protected]>
Date:   Thu Mar 18 02:51:11 2021 +0530

    Cluster state applier stats (#282)

    * Publish latency and failure metrics for cluster state applier thread

    * Publish latency and failure metrics for cluster state applier thread

    * Extract MetricsTracker

    * Add Javadoc for Metrics Tracker

    * Add ClusterStateApplierStats to collect latency and failure metrics

    * Add ClusterStateApplierStats to collect latency and failure metrics

    * Added UTs for ClusterApplierServiceStatsCollector

    * Added UTs for ClusterApplierServiceStatsCollector

    * Java doc changes

    Co-authored-by: Arpita Mathur <[email protected]>

commit 253229a24f49b5479333d8ffda7167441e39162a
Merge: 7c5cb8e6 52e5cc4
Author: Khushboo Rajput <[email protected]>
Date:   Mon Mar 8 22:06:07 2021 -0800

    Merge branch 'main' into aes_7.10_nightly

commit 52e5cc4
Author: Mital Awachat <[email protected]>
Date:   Tue Mar 9 10:49:11 2021 +0530

    Track admission control metrics (#290)

    * Track admission control metrics

    Co-authored-by: Mital Awachat <[email protected]>

commit c280915
Author: Dharmesh <[email protected]>
Date:   Thu Mar 4 23:12:37 2021 +0530

    [Bug Fix] Incorrect metric value was returned from the getter of current bytes (#287)

commit 7c5cb8e63cde9023084ab57075bbdf554df9748c
Merge: 28ee8302 a997189
Author: Khushboo Rajput <[email protected]>
Date:   Thu Mar 4 09:39:54 2021 -0800

    Merge branch 'main' into aes_7.10_nightly

commit a997189
Author: Dharmesh <[email protected]>
Date:   Thu Mar 4 10:55:36 2021 +0530

    Added metrics publishing logic (#285)

commit 28ee8302529c279dfadc47bf9b0d4f6b6d91ac75
Author: Dharmesh <[email protected]>
Date:   Tue Mar 2 23:49:47 2021 +0530

    Adding a additional check to just process first 50 objects of hot store (#284)

commit 0d2566a61bab1531400eaae486c3734bcea386fe
Author: Dharmesh <[email protected]>
Date:   Tue Mar 2 11:33:35 2021 +0530

    Changes to collect shard indexing pressure metrics and push to shared location (#278)

    * Changes to collect shard indexing pressure metrics and push to shared location

    * Code changes to remove pushing the cold store objects and removing isActiveShard flag as it becomes irrelevant now

    * Addressing comment to change NodeRole to IndexingStage as node role already has a predefined meaning

    * Checking if class is present while adding the collector in scheduled executor so that the collector will never be invoked if class in not present

    * Addressing comments.

commit 819d485
Author: Dharmesh <[email protected]>
Date:   Tue Mar 2 23:49:47 2021 +0530

    Adding a additional check to just process first 50 objects of hot store (#284)

commit 2f3df02
Author: Dharmesh <[email protected]>
Date:   Tue Mar 2 11:33:35 2021 +0530

    Changes to collect shard indexing pressure metrics and push to shared location (#278)

    * Changes to collect shard indexing pressure metrics and push to shared location

    * Code changes to remove pushing the cold store objects and removing isActiveShard flag as it becomes irrelevant now

    * Addressing comment to change NodeRole to IndexingStage as node role already has a predefined meaning

    * Checking if class is present while adding the collector in scheduled executor so that the collector will never be invoked if class in not present

    * Addressing comments.

commit 9f83059
Author: Yu Sun <[email protected]>
Date:   Fri Feb 26 14:36:02 2021 -0800

    Log error once only (#280)

commit 3377c2f
Author: Karthik Kumarguru <[email protected]>
Date:   Mon Feb 22 15:11:45 2021 -0800

    Increase the max heap limit to check against in the integ tests (#277)

commit 641b403f941596f543e95a01b9a5795b73d7fd65
Author: Khushboo Rajput <[email protected]>
Date:   Sat Feb 20 12:45:57 2021 -0800

    Creating new brand for ES 7.10 version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants