Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Upgrading commons-beanutils to 1.9.4 #248

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Upgrading commons-beanutils to 1.9.4 #248

merged 2 commits into from
Nov 25, 2020

Conversation

khushbr
Copy link
Contributor

@khushbr khushbr commented Nov 24, 2020

Fixes #, if available: #247

Description of changes: Upgrading commons-beanutils to 1.9.4. This commons-beanutils:commons-beanutils:1.9.3 is coming from com.puppycrawl.tools:checkstyle:8.20. Added 'checkstyle' plugin with 'com.puppycrawl.tools:checkstyle:8.37' dependency. Also, added checkstyle.xml

checkstyle - The Checkstyle libraries to be used for this project.
\--- com.puppycrawl.tools:checkstyle:8.20
     +--- info.picocli:picocli:3.9.6
     +--- antlr:antlr:2.7.7
     +--- org.antlr:antlr4-runtime:4.7.2
     +--- commons-beanutils:commons-beanutils:1.9.3
     |    \--- commons-collections:commons-collections:3.2.2
     +--- com.google.guava:guava:27.1-jre
     |    +--- com.google.guava:failureaccess:1.0.1
     |    +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     |    +--- com.google.code.findbugs:jsr305:3.0.2
     |    +--- org.checkerframework:checker-qual:2.5.2
     |    +--- com.google.errorprone:error_prone_annotations:2.2.0
     |    +--- com.google.j2objc:j2objc-annotations:1.1
     |    \--- org.codehaus.mojo:animal-sniffer-annotations:1.17
     \--- net.sf.saxon:Saxon-HE:9.9.1-2
          \--- com.ibm.icu:icu4j:63.1

Post the Update.

khushbr@3c22fb8556dd performance-analyzer % ./gradlew dependencies | grep commons-beanutils
|    +--- commons-beanutils:commons-beanutils:1.9.4


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sruti1312
sruti1312 previously approved these changes Nov 24, 2020
Comment on lines +183 to +184
checkstyleMain.ignoreFailures = true
checkstyleTest.ignoreFailures = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to ignoreFailures?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now. The new checkstyle plugin version is ahead of the gradle checktyle, and brings in a lot of changes for OperatorWrap, CustomImportOrder EmptyLineSeparator etc. Since I want to keep this change minimal, I am putting checkstyleMain.ignoreFailures as true for now.

@khushbr khushbr merged commit 380248a into master Nov 25, 2020
@khushbr khushbr deleted the khushbr-pa-cve branch November 25, 2020 00:28
khushbr added a commit that referenced this pull request Nov 25, 2020
commit 380248a
Author: Khushboo Rajput <[email protected]>
Date:   Tue Nov 24 16:28:49 2020 -0800

    Upgrading commons-beanutils to 1.9.4 (#248)

commit 43f7f24
Author: Khushboo Rajput <[email protected]>
Date:   Tue Nov 24 15:10:23 2020 -0800

    Updating the com.github.spotbugs to latest 4.6.0 version (#250)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants