Stop emit default value for counter TotalError and ReaderRestartProce…

…ssing
opendistro-for-elasticsearch · Mar 15, 2021 · 5cce866 · 5cce866
1 parent 2ac7704
commit 5cce866
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/.../java/com/amazon/opendistro/elasticsearch/performanceanalyzer/PerformanceAnalyzerApp.java b/.../java/com/amazon/opendistro/elasticsearch/performanceanalyzer/PerformanceAnalyzerApp.java
@@ -121,8 +121,6 @@ public static void main(String[] args) {
               (MetricsConfiguration.CONFIG_MAP.get(StatsCollector.class).samplingInterval) / 2,
               TimeUnit.MILLISECONDS);
       METRIC_COLLECTOR_EXECUTOR.addScheduledMetricCollector(StatsCollector.instance());
-      StatsCollector.instance()
-          .addDefaultExceptionCode(StatExceptionCode.READER_RESTART_PROCESSING);
       METRIC_COLLECTOR_EXECUTOR.setEnabled(true);
       METRIC_COLLECTOR_EXECUTOR.start();
 

diff --git a/...va/com/amazon/opendistro/elasticsearch/performanceanalyzer/collectors/StatsCollector.java b/...va/com/amazon/opendistro/elasticsearch/performanceanalyzer/collectors/StatsCollector.java
@@ -124,7 +124,6 @@ public StatsCollector(String name, int samplingIntervalMillis, Map<String, Strin
     super(samplingIntervalMillis, name);
     this.metadata = metadata;
     addRcaVersionMetadata(this.metadata);
-    defaultExceptionCodes.add(StatExceptionCode.TOTAL_ERROR);
   }
 
   private StatsCollector(Map<String, String> metadata) {

diff --git a/...a/com/amazon/opendistro/elasticsearch/performanceanalyzer/PerformanceAnalyzerAppTest.java b/...a/com/amazon/opendistro/elasticsearch/performanceanalyzer/PerformanceAnalyzerAppTest.java
@@ -26,5 +26,7 @@ public void testMain() {
     PerformanceAnalyzerApp.main(new String[0]);
     Assert.assertFalse(ConfigStatus.INSTANCE.haveValidConfig());
     Assert.assertEquals(StatsCollector.instance().getCounters().get("ReaderThreadStopped").get(), 1);
+    Assert.assertEquals(StatsCollector.instance().getCounters().get("TotalError").get(), 1);
+    Assert.assertFalse(StatsCollector.instance().getCounters().containsKey("ReaderRestartProcessing"));
   }
 }