This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 166
Description of changes:
This PR is inherited from #166.
Implementations are adapted from #166 for use with
LocalUriInput
.Internal Changes
HttpInput
toLocalUriInput
to reflect that this feature only supports local clusters at this time. Only apath
field has been exposed ashost
andport
only supportlocalhost
and9200
for now.create monitor
,edit monitor
, andcreate trigger
pages display properly forLocalUriInput
type monitors.formikToMonitor.js
to handleLocalUriInput
type monitors.LocalUriInput.test.js
snapshot test.formikToInputs()
andformikToLocalUri()
informikToMonitor.test.js
.can build LocalUriInput monitor
test tomonitorToFormik.test.js
.External Changes
getOverviewStats
to displayLocal URI
definition type.Response
block on the create monitor page will display the response contents for the API called using the providedpath
.CreateTrigger.js
such that theTrigger Condition
block on the create trigger page will display the first field name in the API response for LocalUriInput monitors (e.g.,ctx.results[0].XXX != null
).UX Screenshots
Additional option in the 'define monitor' dropdown menu
The 'Create Monitor' page
The 'Create Trigger' page
The 'Monitor Overview' page
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.