fix(api-client): Fix Facet types to match API v2.1 #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal for this PR is to fix a mismatch between
Facet
type and the reality of what the API provides.(Internal for Opendatasoft only) Associated Shortcut ticket: sc-44362.
Changes
The changes are made to match the current structure of both facets endpoint in the API.
Changelog
Facet
types has been fixed to properly match Opendatasoft's API responses.Open discussion
I added
state
as a very simple type without an enum. I don't think it's worth adding an enum here.Review checklist