-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use targetNamespace for authorino feature #908
base: incubation
Are you sure you want to change the base?
chore: use targetNamespace for authorino feature #908
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
extAuthzErr := feature.CreateFeature("mesh-control-plane-external-authz"). | ||
For(handler). | ||
TargetNamespace(authNs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a change in mesh-authz-ext-provider.patch.tmpl
is missing:
https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/pkg/feature/templates/servicemesh/authorino/mesh-authz-ext-provider.patch.tmpl#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest putting this PR on hold for the time being, as I am reworking the f.Spec
stuff entirely.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cam-garrison: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
This PR uses TargetNamespace for the authorino feature, removing the need for the helper ResolveAuthNamespace() function.
How Has This Been Tested?
Tested on CRC with image
quay.io/cgarriso/opendatahub-operator:dev-use-target-ns
, created DSCI with default auth namespace and saw that authorino pod was created in targetNSopendatahub-auth-provider
as expected and then specified in DSCI with namespaceauth-provider
to ensure specifying still works.Merge criteria: