Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use targetNamespace for authorino feature #908

Draft
wants to merge 2 commits into
base: incubation
Choose a base branch
from

Conversation

cam-garrison
Copy link
Contributor

Description

This PR uses TargetNamespace for the authorino feature, removing the need for the helper ResolveAuthNamespace() function.

How Has This Been Tested?

Tested on CRC with image quay.io/cgarriso/opendatahub-operator:dev-use-target-ns, created DSCI with default auth namespace and saw that authorino pod was created in targetNS opendatahub-auth-provider as expected and then specified in DSCI with namespace auth-provider to ensure specifying still works.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ajaypratap003 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cam-garrison cam-garrison removed the request for review from lucferbux March 8, 2024 21:07
extAuthzErr := feature.CreateFeature("mesh-control-plane-external-authz").
For(handler).
TargetNamespace(authNs).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest putting this PR on hold for the time being, as I am reworking the f.Spec stuff entirely.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Apr 24, 2024

@cam-garrison: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-pr-image-mirror 62878eb link true /test opendatahub-operator-pr-image-mirror
ci/prow/ci-index 62878eb link true /test ci-index
ci/prow/opendatahub-operator-e2e 62878eb link true /test opendatahub-operator-e2e
ci/prow/images 62878eb link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants