-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: move params.env image updating to Init stage #1191
base: incubation
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,10 @@ type Component struct { | |
DevFlags *DevFlags `json:"devFlags,omitempty"` | ||
} | ||
|
||
func (c *Component) Init(_ context.Context, _ cluster.Platform) error { | ||
return nil | ||
} | ||
Comment on lines
+42
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why need this? you foresee some component might not have implementation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Frankly put just in case. Can remove. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thought was left from the first commit, when only one component implemented with Init(..) at that time. |
||
|
||
func (c *Component) GetManagementState() operatorv1.ManagementState { | ||
return c.ManagementState | ||
} | ||
|
@@ -78,6 +82,7 @@ type ManifestsConfig struct { | |
} | ||
|
||
type ComponentInterface interface { | ||
Init(ctx context.Context, platform cluster.Platform) error | ||
ReconcileComponent(ctx context.Context, cli client.Client, logger logr.Logger, | ||
owner metav1.Object, DSCISpec *dsciv1.DSCInitializationSpec, platform cluster.Platform, currentComponentStatus bool) error | ||
Cleanup(ctx context.Context, cli client.Client, owner metav1.Object, DSCISpec *dsciv1.DSCInitializationSpec) error | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also update docs on https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/pkg/deploy/envParams.go#L67
just to be clear that it only update if it does not match otherwise it wont do anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean 450e19f ("deploy: ApplyParams: do not write params.env if there are no updates (#1186)") functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, by reading the comments, i do not feel it reflects what the fuction is doing with recent chagnes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's anyway unrelated to this patchset, can come as fixup for the aforementioned patch.