-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ready for 1.9 release #627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that there is a document returned from parse_doc_stream, so a zero byte file does not crash s3_to_dc.
Fix miniconda installation. Separate GDAL linker issue surfaces.
* update reqs * same docker v_pgis as core * update workflow * fix test setup * use Miniforge3 * add docker to test env --------- Co-authored-by: Ariana Barzinpour <[email protected]>
Changes for indexing new sentinel-2 collection in deafrica odc (#612) * changes for indexing new sentinel-2 collection in deafrica odc * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Adding test for deafrica s2_l2a_c1 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * formatting * formatting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * bumping version * specific test for relative/absolute path conversion * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change test to equal src link * Adjusted expected data for easier bug detection. * Oops I dropped an e - restoring. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Paul Haesler <[email protected]>
Add docker to test requirements. (#613) * Add docker to test requirements. * Add docker to test requirements again?? * Docker in conda env? * Conda calls it docker-py? * Fix stac transform tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * xfail broken lib-cloud tests. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * xfail broken lib-cloud tests. * xfail broken lib-cloud tests. * Revert to old relative url handling. * Roll back version number * Catch different bucket case. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Satisfy pylint * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Satisfy pylint * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Satisfy pylint --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Check that there is a document returned from parse_doc_stream, so a zero byte file does not crash s3_to_dc.
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/psf/black: 24.4.2 → 24.10.0](psf/black@24.4.2...24.10.0) - [github.com/PyCQA/pylint: v3.2.3 → v3.3.1](pylint-dev/pylint@v3.2.3...v3.3.1) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.1](PyCQA/flake8@7.0.0...7.1.1)
Previously, a postgres data directory was being manually created using the low level postgres admin tools like initdb and pg_ctl. This broke, because the Ubuntu postgresql package moved those tools to /usr/lib/postgresql/14/bin. When I added that to the path, the server still failed to start, so lets use the more common pattern within GHA, and run Postgresql as a service, updating the environment variables to use it.
updates: - [github.com/PyCQA/pylint: v3.3.1 → v3.3.2](pylint-dev/pylint@v3.3.1...v3.3.2)
for more information, see https://pre-commit.ci
9519879
to
83e504c
Compare
The versions had drifted and we were using one from local and one from remote, which was making all the tests fail.
omad
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ariana-B !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the two 1.9-compatible branches along with cherrypicks from main, ready for formal 1.9 release