-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: save COGs with dask to azure #195
base: develop
Are you sure you want to change the base?
feat: save COGs with dask to azure #195
Conversation
9bd48c9
to
7b6b553
Compare
@wietzesuijker thanks for the PR. Can I ask you to undo
I'll need to find some time to review this properly and to remember what was the original plan for extending to other blob stores. At this point I'm not convinced we need a base class, but my memory of this code is hazy. In the meantime please
|
00d3ff0
to
d80b5cd
Compare
Thanks @Kirill888; I addressed your suggestions. If you're not too familiar with Azure and want to give it a spin, you can:
Thanks again, and great to have your input on this! |
69198e5
to
a54072f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #195 +/- ##
===========================================
- Coverage 95.48% 94.05% -1.43%
===========================================
Files 31 33 +2
Lines 5532 5649 +117
===========================================
+ Hits 5282 5313 +31
- Misses 250 336 +86 ☔ View full report in Codecov by Sentry. |
Optional Dependency HandlingExample: odc-geo/odc/geo/_xr_interop.py Lines 55 to 61 in 62b7c5e
The Lines 22 to 28 in 62b7c5e
Add TestsWe use odc-geo/tests/test_converters.py Lines 6 to 9 in 62b7c5e
PackagingAdd optional Lines 54 to 60 in 62b7c5e
Run checks locally
Simplifying Review processThere is now quite a bit of cleanup changes here, let's have those in a separate PR that I can merge, then we can focus on actual change without getting bogged down by all the mypy harmonization changes. |
Added a PR for the cleanup. I'll give the rest another push tomorrow (UK time). Hopefully, that will give us enough time to review before the holiday season; if not, we can review again in 2025 :). |
@wietzesuijker other PR is merged, and some other changes, please rebase this against main. |
db0c6f1
to
672944d
Compare
Thanks @Kirill888! I didn't get as much done as I'd liked. I updated the test for az and started using |
672944d
to
4f136cb
Compare
@wietzesuijker there is currently a conflict after merging your other PR, can you please rebase this branch against |
7ffe111
to
0802a9f
Compare
Merged branch 'develop' into feat/save-cog-to-azure.
0802a9f
to
bc8811c
Compare
9db7b9a
to
ad98235
Compare
395f266
to
e1b6187
Compare
- Restored type hints in `upload` for improved type safety. - Added `get_mpu_kwargs` to centralize shared keyword arguments. - Simplified `upload` and `mpu_upload` implementations by reusing `get_mpu_kwargs`. - Reduced code duplication across `_mpu.py` and `_multipart.py`.
e1b6187
to
9fcc5d5
Compare
@Kirill888 I've added some changes to fix non-related mypy errors in 3b0223c and squashed that with your commit. The tests pass (after a few tries), and the basic example in the description of the PR still works. |
This PR introduces Azure Blob Storage support for saving COGs with Dask, complementing the existing AWS S3 support.
Here’s a simple test I ran to verify the Azure implementation:
While implementing this, I noticed a couple of quirks in the original code:
ise
rather thanize
.As this is my first PR here, I look forward to feedback and suggestions for improvement!