Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: fixate GDAL version #620

Merged

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Jul 25, 2024

Building from gdal-latest will make
the explorer 2.12.3 image unbuildable
when gdal-latest suddenly contains
breaking changes.

Fixate the image version to keep old
releases of explorer buildable even
in the future.


📚 Documentation preview 📚: https://datacube-explorer--620.org.readthedocs.build/en/620/

Building from gdal-latest will make
the explorer 2.12.3 image unbuildable
when gdal-latest suddenly contains
breaking changes.

Fixate the image version to keep old
releases of explorer buildable even
in the future.
@pjonsson
Copy link
Contributor Author

@Ariana-B I try to stay up to date with releases, but there are a lot of things to keep up with, so when I fall behind it's valuable for me if the old releases remain buildable.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (aa0d9f3) to head (07a2171).
Report is 116 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
+ Coverage    86.29%   87.82%   +1.53%     
===========================================
  Files           26       26              
  Lines         3451     3598     +147     
===========================================
+ Hits          2978     3160     +182     
+ Misses         473      438      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ariana-B Ariana-B self-requested a review July 26, 2024 01:19
Copy link
Contributor

@Ariana-B Ariana-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not thought of that - good catch, and thank you!

@Ariana-B Ariana-B merged commit d1e3ffa into opendatacube:develop Jul 26, 2024
7 checks passed
@pjonsson pjonsson deleted the dockerfile-fixed-gdal-version branch July 26, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants