Fix premature connection closure #1525
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Github action fixes, backported from develop-1.9 * Updates to whats_new.rst * Capitalise "Dependabot" in whats_new.rst
We used to deploy to netlify for docs previews, but now that's done to Read The Docs. The old Workflow should be removed.
updates: - [github.com/adrienverge/yamllint.git: v1.30.0 → v1.31.0](https://github.com/adrienverge/yamllint.git/compare/v1.30.0...v1.31.0)
for more information, see https://pre-commit.ci
Error message for missing arguments
add license hook to pre-commit
Allow open date range in dataset search
* support open ended date range in query init * allow open ended time ranges in load() and find_datasets(), also simplify logic for cli * update doco and whats_new * get end of datetime.now() to avoid failing tests due to second mismatches * Minor update to documentation Even with open bounds, dates are still inclusive of the start and end dates. Minor update to wording to make this clearer --------- Co-authored-by: Ariana Barzinpour <[email protected]> Co-authored-by: Robbi Bishop-Taylor <[email protected]>
updates: - [github.com/adrienverge/yamllint.git: v1.31.0 → v1.32.0](https://github.com/adrienverge/yamllint.git/compare/v1.31.0...v1.32.0)
* Pass X and Y Scale factors through to rasterio.warp.project. Update whats_new * Update PR number in whats_new.rst * Remove unused import. * Cleanup. * Cleanup. * Should probably just add it to the dictionary tbh. * Respond to Kirill's comments.
add archive_less_mature option to add and update
Better archiving error
* don't archive less mature if value is False instead of None * update whats_new * update delta typehint, improve type/value validation * add warning message if delta is bool * fix type check * add test for not archiving less mature, fix find less mature type check * fix logic for real this time --------- Authored-by: Ariana Barzinpour <[email protected]>
* Require Python >=3.9 Add tags for Py 3.10 and 3.11. * Remove conda tests for 3.8. Add for 3.10 and 3.11. * Updated Whats new.rst * Bump lint.yaml GHA to Py3.9 * Updated PR number * Require Python >=3.9 Add tags for Py 3.10 and 3.11. * Remove conda tests for 3.8. Add for 3.10 and 3.11. * Updated Whats new.rst * Bump lint.yaml GHA to Py3.9 * Updated PR number
* Update whats_new.rst with release notes. * Manually apply recent dependabot upgrades. * Removed some lingering references to Python3.8+ (including conda-environment.yml)
* Suppress SQLAlchemy warnings. * Fixed spelling mistake in whats_new and fixed drop schema where no schema does not exist. * Switch to jsonschema 4.18+ "references" API. * Rebase onto develop. * Add repin (as in pin again) to the dictionary. * Ugh - could have sworn this was working on Friday.
updates: - [github.com/adrienverge/yamllint.git: v1.32.0 → v1.33.0](https://github.com/adrienverge/yamllint.git/compare/v1.32.0...v1.33.0)
Bumps [conda-incubator/setup-miniconda](https://github.com/conda-incubator/setup-miniconda) from 2 to 3. - [Release notes](https://github.com/conda-incubator/setup-miniconda/releases) - [Changelog](https://github.com/conda-incubator/setup-miniconda/blob/main/CHANGELOG.md) - [Commits](conda-incubator/setup-miniconda@v2...v3) --- updated-dependencies: - dependency-name: conda-incubator/setup-miniconda dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
* add dataset cli tool to find duplicates * convert timestamps to UTC * update whats_new * update memory driver search duplicates implementation --------- Co-authored-by: Ariana Barzinpour <[email protected]>
* warn if non-eo3 dataset has eo3 metadata type * fix str contains * add test --------- Co-authored-by: Ariana Barzinpour <[email protected]>
…nci closing connection prematurely
SpacemanPaul
force-pushed
the
develop
branch
from
22cced7 to
39c96e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
On servers that aggressively close idle connections (e.g. NCI), the connection is sometimes closed prematurely when combining db calls with file io or writing to logs.
Proposed changes
Connection.execution_optionsdoesn't modify the connection in-place until sqlalchemy 2.0; make current implementation compatible with both 1.4 and 2.0Don't set connection isolation level to autocommit when calling
_connect, as it is already set on the engine levelCloses #xxxx
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1525.org.readthedocs.build/en/1525/