Change model and data for new LSTM layer test #2 #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
asmorkalov
approved these changes
Nov 20, 2024
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Nov 20, 2024
…-latest LSTM layer for new graph engine. #26391 Merge with extra: opencv/opencv_extra#1218 This PR updates/creates LSTM layer compatible with new graph engine. It is based on previous LSTM implementation with some modification on how initializers blobs are processed. Note: Following tests are currently are disabled Two following two tests are disbled since ONNNRuntime does not support `layout=1` attiribute inference. See a detailed issue #26456 on this. - `LSTM_layout_seq` - `LSTM_layout_batch` Following test fails with the new engine as it is not able to deal with shapes of the form [?, C, H, W] - `LSTM_Activations` Works: - [x] One directional case any batch type - [x] Fix directional case when batch size large than 1 - [x] Add peepholes attribute TODO with the next PRs: - [ ] Activation support Note: > Currently `LSTM_layout_seq`, `LSTM_layout_batch` are disabled as the tests are incorrect. They do not comply with the ONNX standard. Particularly test outputs are of incorrect dimensionality. They produce 3-dimentinal output instead of 4-dimentional. ------ ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test data generation model and data for #26391 since the test was written inccorrect and did not comply with the ONNX specificaiton. Main LSTM output Y should be of dimention 4 as opposed to 3 and of the following form
Y - [seq_length, num_directions, batch_size, hidden_size]