FastCV Extension code for Opencv #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I721b810181dd9127221b6e2182d7aad5ac679b68
cleanup and added make rules to download the fastcv bins from the 3rdparty repo Change-Id: I9a9db68a310263658ec93ea299ea37860d07c507
- Reused FastCV search and variables from main OpenCV - Reorganized headers in OpenCV style to make them compatible with bindings generator - Disabled bindings for some functions as they are not generated automatically - Fixed build
6 tasks
asmorkalov
approved these changes
Dec 2, 2024
Comment on lines
+13
to
+27
| { | ||
| cv::Size size = get<0>(GetParam()); | ||
| int d = get<1>(GetParam()); | ||
| double sigmaColor = get<2>(GetParam()); | ||
| double sigmaSpace = sigmaColor; | ||
|
|
||
| RNG& rng = cv::theRNG(); | ||
| Mat src(size, CV_8UC1); | ||
| cvtest::randUni(rng, src, Scalar::all(0), Scalar::all(256)); | ||
|
|
||
| cv::Mat dst; | ||
|
|
||
| cv::fastcv::bilateralFilter(src, dst, d, sigmaColor, sigmaSpace); | ||
|
|
||
| EXPECT_FALSE(dst.empty()); |
There was a problem hiding this comment.
There is some indentation issue.
|
This PR merge causes several documentation warnings: |
|
Problem is clearly visible on CI - stop merging against RED CI ! http://pullrequest.opencv.org/buildbot/builders/precommit-contrib_docs/builds/101305 |
|
If you don't use "legacy CI" - why we still don't have any GitHub Actions documentation builder for |
|
Addressed in #3839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on opencv/opencv#26316
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.