Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wechat_qrcode: fix ineffective decoding retrial after inverting image #3818

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Doekin
Copy link
Contributor

@Doekin Doekin commented Oct 26, 2024

This PR fixes a logic error in the QRCodeReader::decode function
when handling inverted images. Previously, the function would return
an empty result list even when successful decoding occurred on an
inverted image. The change ensure that:

  1. If decoding fails on the original image, we attempt decoding on an inverted image.
  2. If decoding succeeds on the inverted image, we now correctly return those results.
  3. We maintain the behavior of returning an empty list if both original and inverted image decoding fail.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from VadimLevin October 29, 2024 12:56
@asmorkalov asmorkalov merged commit 475f6fa into opencv:4.x Nov 12, 2024
10 of 11 checks passed
@asmorkalov asmorkalov mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants