Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudaarithm: fix python bindings for binary ops involving scalars #3815

Merged

Conversation

cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Oct 24, 2024

Fix #3814 by adding python specific overloads.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general.

@cudawarped cudawarped force-pushed the cuda_fix_python_binaryop_with_scalar branch from 826e85a to 06ddcce Compare October 29, 2024 13:43
@asmorkalov asmorkalov merged commit 5741f22 into opencv:4.x Oct 31, 2024
11 checks passed
@asmorkalov asmorkalov mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cudaarithm: binary operations involving a scalar don't work in python
2 participants