-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get CUDA code to compile with clang CUDA and without CUDA #3800
Conversation
On Windows this is an annoying default in Visual Studio, what errors does clang give from this? I'm concerned that if any new kernel's are added by users of VS then it will brake the clang build. Strangely it build fine for me on Ubuntu 20:04 - clang version 10.0.0-4ubuntu1. |
Thx @cudawarped . I am ok fixing the
|
@vrabaud Could you add some notes how you build OpenCV + CUDA + Clang. Just to be sure that we are talking about the same thing. |
@asmorkalov , for my purpose, I do not use nvcc but clang cuda instead. This is all internal to Google so I actually have no idea of the command lines unfortunately. |
I am done adding missing implementations, PTAL |
Changelist:
<< <
-><<<
. For some reason, I do not need to change all those in the code.::min
->std::min
in__host__
codemodules/cudaimgproc/src/moments.cpp
needs to have the CUDA code in the#ifdef
cv::cuda::swapChannels
is not exactly the same as the C++ one inmodules/cudaimgproc/src/color.cpp
cv::cuda::FarnebackOpticalFlow::create
needs to be explicit about which FarnebackOpticalFlow it returnsPull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request