Fix OCRBeamSearchDecoder bug: a risk of assigning value to NULL. #3790
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Details
In text module, class OCRBeamSearchDecoder has some

run
methods:These methods will execute OCRBeamSearchDecoderImpl::run:
However, some parameters can be NULL, but this method does not check for this when assigning values to them at the end of the method.
Actually, some OCRBeamSearchDecoder::run methods must fail because they indeed pass one parameter as NULL when executing the upper method:
What's worse,


python
can only some warp methods which execute upper methods . Using OCRBeamSearch in python must fail.The following code must throw error: Unknown C++ exception from OpenCV code.