Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgproc: use double to determine whether the corners points are within src #3778

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Kumataro
Copy link
Contributor

@Kumataro Kumataro commented Aug 14, 2024

Related opencv/opencv#26022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro Kumataro changed the title workaround for Rect.contains(Point2f/2d) imgproc: use double to determine whether the corners points are within src Aug 14, 2024
@asmorkalov asmorkalov self-requested a review August 23, 2024 08:02
@asmorkalov asmorkalov self-assigned this Aug 23, 2024
@asmorkalov asmorkalov merged commit 94cda4b into opencv:4.x Aug 23, 2024
10 of 11 checks passed
asmorkalov pushed a commit to opencv/opencv that referenced this pull request Aug 23, 2024
Imgproc: use double to determine whether the corners points are within src #26022

close #26016
Related opencv/opencv_contrib#3778

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants