Skip to content

aruco: add back missing samples and tutorials testdata #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rurban
Copy link

@rurban rurban commented Mar 28, 2024

fixes the aruco test regressions.
copy back 2 objdetect tutorial images, moved over.

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

issue report: SpexAI#1

fixes the aruco test regressions.
copy back 2 objdetect tutorial images, moved over.
@AleksandrPanov
Copy link
Contributor

AleksandrPanov commented Mar 28, 2024

@rurban, gboriginal.jpg and singlemarkersoriginal.jpg were moved to opencv_extra/testdata/cv/aruco:
https://github.com/opencv/opencv_extra/tree/4.x/testdata/cv/aruco
These images do not need to be returned to contrib.

@AleksandrPanov
Copy link
Contributor

Contrib Aruco tests work on OpenCV CI:
image

Copy link
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gboriginal.jpg and singlemarkersoriginal.jpg were moved to opencv_extra/testdata/cv/aruco:
https://github.com/opencv/opencv_extra/tree/4.x/testdata/cv/aruco
These images do not need to be returned to contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants