added getColorCharts() #3645
Merged
added getColorCharts() #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrPanov
added
feature
category: documentation
AleksandrPanov
force-pushed
the
update_mcc_CCHecker
branch
from
3c74b02 to
c0aa450
Compare
asmorkalov
reviewed
Mar 1, 2024
| * and find by this the coordinates of the central parts of the charts modules. | ||
| * It is used in `cv::mcc::CCheckerDraw::draw()` and in `ChartsRGB` calculation. | ||
| */ | ||
| CV_WRAP virtual std::vector<Point2f> getComputedCharts() = 0; |
There was a problem hiding this comment.
M.b. getColorCharts() is more relevant.
There was a problem hiding this comment.
Mb getComputedColorCharts()?
There was a problem hiding this comment.
I propose to name it getColorCharts without computed. The function behaviour may change.
|
Could you add the new method to test(s) and at least one of the samples. |
Method But now I'm adding a stronger test. |
AleksandrPanov
force-pushed
the
update_mcc_CCHecker
branch
from
c0aa450 to
7f445c2
Compare
AleksandrPanov
changed the title
AleksandrPanov
force-pushed
the
update_mcc_CCHecker
branch
from
7f445c2 to
45f560b
Compare
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge this PR after #3647
Computes and returns the coordinates of the central parts of the charts modules.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.