-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fast guided filter #3623
Conversation
a8a9310
to
74e6ffe
Compare
62b1038
to
195184e
Compare
last github workflow was timed out during execution, kindly asking for a re-run :) @opencv-alalek |
@w43322, thanks for the contribution! We would like to ask you to do a few things:
|
195184e
to
b603a10
Compare
@vpisarev Hi, I've updated the PR, please take a look :)
✅
✅ Did some tests, seems like the runtime is mostly similar across three methods - although INTER_AREA is noticeably slower with
Checking for NORM_INF only works for I've added a new check for scaled images, making sure that the FastGuidedFilter image is less blurry than a naive resampling. Please let me know if you think there are any other checks that are viable.
✅ |
This PR implements fast guided filter. The concept is explained in this paper.
TLDR:
Added a 'scale' parameter to the current guided filter interface, allowing resampling inside the algorithm, to speed up computation. The resampling has to be done inside guided filter because the intermediate result has to be combined with original input to generate the final result.
The performance and behavior of the default code path (scale == 1.0) is unaltered. before vs after
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
- [ ] There is a reference to the original bug report and related workPatch to opencv_extra has the same branch name.