Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudaimgproc: update for CUDA 8.0 and fix out of bounds memory error in cuda::moments #3618

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Jan 5, 2024

Fix #3612 and address out of bounds memory error when not calculating all image moments.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cudawarped cudawarped changed the title cudaimgproc: update for CUDA 8.0 and fix out of bounds memory error cudaimgproc: update for CUDA 8.0 and fix out of bounds memory error in cuda::moments Jan 5, 2024
@asmorkalov
Copy link
Contributor

@cv3d If you are still using this and not calculating all the image moments you may want to apply this fix.

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

modules/cudaimgproc/include/opencv2/cudaimgproc.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Jan 12, 2024
@asmorkalov
Copy link
Contributor

Buildbot issue is not relevant to the PR and fixed in opencv/opencv#24860

@asmorkalov asmorkalov merged commit 504f15c into opencv:4.x Jan 15, 2024
9 of 10 checks passed
@asmorkalov asmorkalov mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moments.cu(19): error: identifier "__shfl_xor_sync" is undefined
2 participants