Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Aruco tutorials and samples to main repo #3401

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

stopmosk
Copy link
Contributor

@stopmosk stopmosk commented Dec 23, 2022

merge with opencv/opencv#23018
merge with merge with opencv/opencv_extra#1143

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 97137ec into opencv:4.x Feb 26, 2024
9 of 10 checks passed
@asmorkalov asmorkalov self-assigned this Feb 26, 2024
asmorkalov pushed a commit to opencv/opencv that referenced this pull request Feb 26, 2024
Move Aruco tutorials and samples to main repo #23018

merge with opencv/opencv_contrib#3401
merge with opencv/opencv_extra#1143

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake

---------
Co-authored-by: AleksandrPanov <[email protected]>
Co-authored-by: Alexander Smorkalov <[email protected]>
@asmorkalov asmorkalov mentioned this pull request Feb 26, 2024
@opencv-alalek
Copy link

Why was it MERGED against RED and outdated CI builds?

  1. CI builds were 1+ month ago (before merge).
  2. CI build is RED: https://pullrequest.opencv.org/buildbot/builders/precommit-contrib_linux64/builds/100973

This cause permanent RED CI pre-commit and regular validation builds.

This was referenced Mar 15, 2024
klatism pushed a commit to klatism/opencv that referenced this pull request May 17, 2024
Move Aruco tutorials and samples to main repo opencv#23018

merge with opencv/opencv_contrib#3401
merge with opencv/opencv_extra#1143

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake

---------
Co-authored-by: AleksandrPanov <[email protected]>
Co-authored-by: Alexander Smorkalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: aruco category: documentation Documentation fix or update, does not affect code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants