Move dietary properties from ingredient model to product model #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the reason for these changes and the problem that they solve
The
knowledge-graph
currently represents dietary properties (vegetarian
,gluten_free
, ...) as flags attached to the returnedproduct
rather than the overallingredient
.In general (we should document the domain model...), an ingredient is a given product in a certain quantity.
It makes sense that the quantity of a product does not affect any of the dietary properties it has, so it does seem logical for these properties to exist on the
product
.Briefly summarize the changes
RecipeIngredient
model to theIngredientProduct
modelHow have the changes been tested?