Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dietary properties from ingredient model to product model #30

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

jayaddison
Copy link
Member

Describe the reason for these changes and the problem that they solve

The knowledge-graph currently represents dietary properties (vegetarian, gluten_free, ...) as flags attached to the returned product rather than the overall ingredient.

In general (we should document the domain model...), an ingredient is a given product in a certain quantity.

It makes sense that the quantity of a product does not affect any of the dietary properties it has, so it does seem logical for these properties to exist on the product.

Briefly summarize the changes

  1. Move the dietary property flags from the RecipeIngredient model to the IngredientProduct model

How have the changes been tested?

  1. Unit test coverage is updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant