Implementations should support zstd #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested review from
jonjohnsonjr,
stevvooe,
sajayantony,
tianon and
cyphar
as code owners
tianon
reviewed
Sep 5, 2024
|
CI will be fixed by #1199 |
sudo-bmitch
force-pushed
the
pr-layers-zstd
branch
from
d77abba
to
9a2ec57
Compare
tianon
reviewed
Sep 12, 2024
manifest.md
Outdated
| Implementations SHOULD also support the following media types: | ||
|
|
||
| - [`application/vnd.oci.image.layer.v1.tar+zstd`](layer.md#zstd-media-types) | ||
| - [`application/vnd.oci.image.layer.nondistributable.v1.tar+zstd`](layer.md#zstd-media-types) ([deprecation notice](./layer.md#non-distributable-layers)) |
There was a problem hiding this comment.
IMO, thanks to the deprecation, we shouldn't actually add this one 🙈
There was a problem hiding this comment.
It reads to me like "hey, new version of the spec says you SHOULD support these media types, but one of them is already deprecated at release time!"
There was a problem hiding this comment.
Rebased and deleted that.
Signed-off-by: Brandon Mitchell <[email protected]>
sudo-bmitch
force-pushed
the
pr-layers-zstd
branch
from
9a2ec57
to
716f83b
Compare
tianon
approved these changes
Sep 12, 2024
sajayantony
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution to #803.