Skip to content

Commit

Permalink
Add TODO.
Browse files Browse the repository at this point in the history
  • Loading branch information
robshakir committed Nov 7, 2023
1 parent 7a6594d commit 7a7b21d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion protomap/proto.go
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,9 @@ func makeWrapper(msg protoreflect.Message, fd protoreflect.FieldDescriptor, val
wasTypedVal = true
}

// TODO(robjs): Support wpb.IntValue and wpb.BoolValue and add corresponding
// tests.

newV := msg.NewField(fd)
switch newV.Message().Interface().(type) {
case *wpb.StringValue:
Expand All @@ -975,7 +978,6 @@ func makeWrapper(msg protoreflect.Message, fd protoreflect.FieldDescriptor, val
}
nsv = uint64(iv)
}

return (&wpb.UintValue{Value: nsv}).ProtoReflect(), true, nil
case *wpb.BytesValue:
bv, ok := val.([]byte)
Expand Down

0 comments on commit 7a7b21d

Please sign in to comment.