Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay Agent helper: add support for source, hostname, and network instance #1191

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rachidtt
Copy link

This is a follow-up and update to #964 #951 . More context can be found there

Change Scope

  • Replace “helper-address” leaf-list with keyed list
  • Update address type to be oc:inet:host to support ip and hostname configuration
  • Add support for source-interface or source-address configuration
  • Add option to specify network-instance
  • This change is backwards compatible

Platform Implementations

New tree (relevant changes):

  +--rw relay-agent
     +--rw dhcp
     |  +--rw interfaces
     |     +--rw interface* [id]
     |        +--rw id                          -> ../config/id
     |        +--rw config
     |        |  +--rw id?                 oc-if:interface-id
     |        |  +--rw enable?             boolean
     |        |  x--rw helper-address*     inet:ip-address
     |        |  +--rw helper-addresses
     |        |     +--rw helper-address* [address]
     |        |        +--rw address    -> ../config/address
     |        |        +--rw config
     |        |        |  +--rw address?            oc-inet:host
     |        |        |  +--rw local-address?      union
     |        |        |  +--rw network-instance?   oc-ni:network-instance-ref
     |        |        +--ro state
     |        |           +--ro address?            oc-inet:host
     |        |           +--ro local-address?      union
     |        |           +--ro network-instance?   oc-ni:network-instance-ref
     |        +--ro state
     |        |  +--ro id?                 oc-if:interface-id
     |        |  +--ro enable?             boolean
     |        |  x--ro helper-address*     inet:ip-address
     |        |  +--ro helper-addresses
     |        |  |  +--ro helper-address* [address]
     |        |  |     +--ro address    -> ../config/address
     |        |  |     +--ro config
     |        |  |     |  +--ro address?            oc-inet:host
     |        |  |     |  +--ro local-address?      union
     |        |  |     |  +--ro network-instance?   oc-ni:network-instance-ref
     |        |  |     +--ro state
     |        |  |        +--ro address?            oc-inet:host
     |        |  |        +--ro local-address?      union
     |        |  |        +--ro network-instance?   oc-ni:network-instance-ref
     +--rw dhcpv6
        +--rw interfaces
           +--rw interface* [id]
              +--rw id               -> ../config/id
              +--rw config
              |  +--rw id?                 oc-if:interface-id
              |  +--rw enable?             boolean
              |  x--rw helper-address*     inet:ipv6-address
              |  +--rw helper-addresses
              |     +--rw helper-address* [address]
              |        +--rw address    -> ../config/address
              |        +--rw config
              |        |  +--rw address?            oc-inet:host
              |        |  +--rw local-address?      union
              |        |  +--rw network-instance?   oc-ni:network-instance-ref
              |        +--ro state
              |           +--ro address?            oc-inet:host
              |           +--ro local-address?      union
              |           +--ro network-instance?   oc-ni:network-instance-ref
              +--ro state
              |  +--ro id?                 oc-if:interface-id
              |  +--ro enable?             boolean
              |  x--ro helper-address*     inet:ipv6-address
              |  +--ro helper-addresses
              |  |  +--ro helper-address* [address]
              |  |     +--ro address    -> ../config/address
              |  |     +--ro config
              |  |     |  +--ro address?            oc-inet:host
              |  |     |  +--ro local-address?      union
              |  |     |  +--ro network-instance?   oc-ni:network-instance-ref
              |  |     +--ro state
              |  |        +--ro address?            oc-inet:host
              |  |        +--ro local-address?      union
              |  |        +--ro network-instance?   oc-ni:network-instance-ref```


… configure server by hostname. This also adds network-instance.
@rachidtt rachidtt requested a review from a team as a code owner September 25, 2024 15:11
Copy link

google-cla bot commented Sep 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dplore
Copy link
Member

dplore commented Nov 26, 2024

/gcbrun

@OpenConfigBot
Copy link

No major YANG version changes in commit e4a7ce8

Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change suggested. Also, check the linter output. There needs to be a config and state container, and the config container must have config set to true.

Ref: https://gist.github.com/OpenConfigBot/0d4b55defd09566d4bd0bebb7efeb460

release/models/relay-agent/openconfig-relay-agent.yang Outdated Show resolved Hide resolved
release/models/relay-agent/openconfig-relay-agent.yang Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

3 participants