Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define how physical channel power leaves are used. #1189

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Define how physical channel power leaves are used. #1189

merged 3 commits into from
Oct 15, 2024

Conversation

ejbrever
Copy link
Contributor

This change:

  • Removes the "when" statement and allows the descriptions to clarify when/how the leaves should be used.
  • This allows the input-power to be utilized for coherent or standard transceivers. For coherent transceivers, this allows the optical-channel to represent the signal power, while the physical-channel input-power to represent the signal+noise.

More info at:
#1188

@ejbrever ejbrever requested a review from a team as a code owner September 22, 2024 20:17
@ejbrever
Copy link
Contributor Author

@dplore @ahsaanyousaf can you please review? Thanks.

@ahsaanyousaf
Copy link

Thanks for the changes, LGTM

@dplore
Copy link
Member

dplore commented Sep 24, 2024

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Sep 24, 2024 •
edited
Loading

No major YANG version changes in commit 1cab124

@dplore
Copy link
Member

dplore commented Oct 4, 2024

/gcbrun

@dplore dplore added the last-call PR that is in final review before merging. label Oct 4, 2024
@dplore
Copy link
Member

dplore commented Oct 4, 2024

Setting last-call for Oct 10, 2024

@dplore
Copy link
Member

dplore commented Oct 15, 2024

/gcbrun

@dplore dplore merged commit b0ef779 into openconfig:master Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsaanyousaf ahsaanyousaf ahsaanyousaf approved these changes

@dplore dplore dplore approved these changes

Assignees
No one assigned
Labels
last-call PR that is in final review before merging. non-breaking
Projects
OC Operator Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ejbrever @ahsaanyousaf @dplore @OpenConfigBot