-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEEE 802.1AG CFM connectivity management + ITU Y1731 Performance management #1182
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
* Adds references to the following leaf nodes [1] "remote-mep-id" [2] "mac-address" [2] "direction" * Updates description to "maintenance-domain" and adds a reference. * Adds leaf "group-name" to support Ciscoxr vendor implementation of xconnect/bridgedomains to support Ciscoxr implementation * https://github.com/YangModels/yang/blob/main/vendor/cisco/xr/613/Cisco-IOS-XR-ethernet-cfm-cfg.yang#L776C22-L776C33 * Adds "routing-disable" action to support Arista's implementation of link loss forwarding. * Merges ETH-SLM and ETH-LM into loss-measurement config and state. * Creates a common performance-measurement container for all performance-measurement functions i.e. delay & loss. * Moves "loss-measurement" and "delay-measurement" configs and states into a common performance-measurement container. * Moves the previously modeled loss measurement and delay measurement states into a "pm-profiles" container • Adds leaf-ref for "policy-name" associated with the endpoint to refer to the global policy
// Tree view - Commit 4
|
} | ||
} | ||
|
||
uses cfm-top; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be some hierarchical structure to group OAM vs. CFM directly at the root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support this to hopefully get a Juniper LFM augmentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
earies are you suggesting we have an umbrella node; i.e "openconfig/EthernetOAM/cfm"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, how about adding a top level container for /oam
and nesting cfm under that as: /oam/cfm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So a specific proposal is to create a openconfig-oam.yang file with the top level /oam container. Then another file for openconfig-oam-cfm.yang which augments the /oam path.
/gcbrun |
No major YANG version changes in commit 5336cd9 |
* removes trailing spaces. * removes unused and non OC flavoured imports (ietf). * moves leaf nomenclature from "_" to "-" . * add damping timer leaf to LLF feature.
Tree view Commit 7
|
* edit to ccm interval: remove 300ms and add 100ms enum.
Good job @AnnamalaiRajeev. The only thing I couldn't map from our current configs is the option to enable automatic discovery of a MEP. Is there any other way to represent this in the model? Thanks Juniper description: "With automatic discovery a MEP is enabled to accept continuity check messages (CCMs) from all remote MEPs of the same maintenance association. If automatic discovery is not enabled, the remote MEPs must be configured. If the remote MEP is not configured, the CCMs from the remote MEP are treated as errors." |
/gcbrun |
/gcbrun |
AI:
|
…th cfm." This reverts commit fd9e301. * revert commit to pull and push
…into cfm_branch sync remote
/gcbrun |
/gcbrun |
Change Scope
Platform Implementations
// Vendor 1 CiscoXR:
// Vendor 2 Juniper:
https://www.juniper.net/documentation/us/en/software/junos/network-mgmt/topics/topic-map/cfm-configuring.html
// Vendor 3 Nokia:
[Note: Please provide at least two references to implementations which are relevant to the model changes proposed. Each implementation should be from separate organizations.].
// references
[Note: If the feature being proposed is new - and something that is being
proposed as an enhancement to device functionality, it is sufficient to have
reviewers from the producers of two different implementations].